fix(theme): link hover color inside a custom block #2876
Merged
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explicitly sets the
a:hover
style for links inside custom blocks.A link inside a
warning
block uses the yellow theme, but the:hover
uses the brand theme:There's a similar problem for
danger
blocks.It's a bit more complicated for
tip
,info
anddetails
blocks. In theory, they have the same problem. However, the current CSS overrides for those 3 custom blocks set the linkcolor
to--vp-c-brand-1
, which is what it would be anyway. As a result, there isn't a visual inconsistency on:hover
, as it just inherits the defaultcolor
of--vp-c-brand-2
. I've chosen to include an explicit:hover
override for those 3 custom blocks too. It seems inconsistent to set thecolor
fora
but nota:hover
.