Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Return to top' button is always visible #2312

Closed
4 tasks done
Unbinilium opened this issue Apr 29, 2023 · 1 comment
Closed
4 tasks done

'Return to top' button is always visible #2312

Unbinilium opened this issue Apr 29, 2023 · 1 comment
Labels
bug Something isn't working theme Related to the theme

Comments

@Unbinilium
Copy link

Unbinilium commented Apr 29, 2023

Describe the bug

Hello, I noticed that in home layout, on mobile devices (with narrow viewport width), the 'Return to top' button is always visible even you're already at the top, and I have difficulties in hiding this button.

Reproduction

  1. Use a phone browser (with narrow viewport width).
  2. Open https://vitepress.dev, then you'll see the 'Return to top' button is visible.

Expected behavior

  1. It can be automatically hide or show depend on the page location.
  2. It can be explicitly disable in configurations, like themeConfig: { ... returnToTop: false, ...}.

System Info

System:
    OS: macOS 13.3.1
    CPU: (8) arm64 Apple M1
    Memory: 106.47 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.0.0 - /opt/homebrew/bin/node
    npm: 9.6.4 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 112.0.5615.137
    Safari: 16.4
  npmPackages:
    vitepress: ^1.0.0-alpha.74 => 1.0.0-alpha.74

Additional context

Screen.Recording.2023-04-29.at.13.51.35.mov

Validations

@Unbinilium Unbinilium added the bug: pending triage Maybe a bug, waiting for confirmation label Apr 29, 2023
@brc-dd brc-dd added bug Something isn't working theme Related to the theme and removed bug: pending triage Maybe a bug, waiting for confirmation labels Apr 29, 2023
@ATQQ
Copy link
Contributor

ATQQ commented Apr 30, 2023

image

I found out today, too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working theme Related to the theme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants