feat: add filePath to PageData
#2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the edit link pattern function, the current `relativePath` (from `PageData`) is not a file path and hence does not allow to distinguish paths from different packages. Add a new `relativeFilePath` string for this. Keep `relativePath` for compatibility reasons.
4 tasks
chgeo
changed the title
relativeFilePath to PageData for edit link pattern
|
@brc-dd any chance this get merged soon? In our multi-package deployment of Vitepress, the edit button doesn't work for half of the pages. |
chgeo
changed the title
relativeFilePath to PageData for edit link patternrelativeFilePath to PageData
brc-dd
changed the title
relativeFilePath to PageDatafilePath to PageData
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edit link pattern function, the current
relativePath(fromPageData) is not a file path and hence does not allow to distinguish paths from different packages.Add a new
relativeFilePathstring for this. KeeprelativePathfor compatibility reasons.Fixes #2088