Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update chromedriver to 121.0.2 to fix binary CDN URL issue #2144

Merged
merged 1 commit into from Feb 19, 2024

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Feb 19, 2024

The default CDN URL for Chrome binaries has been updated in the past few days. So fresh installations of the chromedriver package will fail with a 404 error. Here's an example in vuejs/ecosystem-ci: https://github.com/vuejs/ecosystem-ci/actions/runs/7954792731/job/21714823187#step:7:5745

This issue was fixed in chromedriver 121.0.2:
giggio/node-chromedriver@06656e9

The default CDN URL for Chrome binaries has been updated in the past few
days. So fresh installations of the chromedriver package will fail with
a 404 error. Here's an example in `vuejs/ecosystem-ci`:
https://github.com/vuejs/ecosystem-ci/actions/runs/7954792731/job/21714823187#step:7:5745

This issue was fixed in `chromedriver` 121.0.2:
giggio/node-chromedriver@06656e9
Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 4694060
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/65d31abe061d07000895b5d7

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9aa1108) 90.88% compared to head (4694060) 90.90%.
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
+ Coverage   90.88%   90.90%   +0.01%     
==========================================
  Files          24       24              
  Lines        1119     1121       +2     
  Branches      347      347              
==========================================
+ Hits         1017     1019       +2     
  Misses         63       63              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit f934fcf into vuejs:main Feb 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants