fix: console logging for component instance proxies #62
+30
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console logging currently fails when the logged value is a component instance proxy:
SFC Playground Example
Those proxies cannot be passed to
String()
without throwing the error:There were a couple of places that potentially pass those proxies to
String()
. The first (line 134) could be removed and replaced by atypeof
check. The second I have replaced with atoString()
helper function that handles error cases more gracefully.The
stringify
function also caused problems because it attempts to enumerate the component's properties, leading to a warning. I've tweaked that to avoid that warning.I've also moved the call to the original log function higher up. This helps to ensure that it still happens, even if an unexpected error occurs in the other code.