Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: minor corrections #2879

Merged
merged 3 commits into from
Jan 6, 2025
Merged

docs: minor corrections #2879

merged 3 commits into from
Jan 6, 2025
+10 −6

Conversation

andrewvasilchuk
Copy link
Contributor

The list of changes:

  • Replaced obscure key symbols with their full, explicit key names for better readability
  • Removed the unused skipHydrate import from certain code snippets
  • Fixed an issue where the ref value was not read correctly by replacing this.list with list.value

@andrewvasilchuk
docs: make keyboards explicit
97b8e0b 
The key symbols are quite obscure; make them explicit by providing the full key names
@andrewvasilchuk
docs: skipHydrate is not used
0ef98bf
@andrewvasilchuk
docs: incorrect usage of this

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
a010dcc
@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit a010dcc
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/677bd966cb697c0008bd190b

@netlify Netlify
Copy link

netlify bot commented Jan 6, 2025 •
edited
Loading

✅ Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit a010dcc
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/677bd96638124c0008920aa2
😎 Deploy Preview https://deploy-preview-2879--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@posva posva merged commit c82e089 into vuejs:v2 Jan 6, 2025
4 checks passed
@andrewvasilchuk andrewvasilchuk deleted the patch-1 branch February 9, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewvasilchuk @posva