docs(ko): add ko-KR translation #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinia-official ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
posva
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Nice! Can you make sure the VueSchool links and carbon ads are present? Similar to how the Spanish docs have them: https://es-pinia.vercel.app/introduction.html
BTW I noticed there is a react({}) instead of reactive({}) in the introduction
niceplugin
commented
Jul 21, 2023
There was a problem hiding this comment.
- I have activated both the VueSchool links and Carbon ads.
- I've made corrections in the introduction to
reactive({}). (I made a mistake in modifying the code text during the translation process.) - I have requested Algolia, but it has not yet been approved.
I'm looking forward to it! Please let me know if you need anything else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been done in the same way as adding a link to the Spanish page.
I have been personally translating and maintaining this document for a year now, and I plan to continue doing so.
I would appreciate it if you could approve this PR so that more Koreans can see it. (Though the translation for the API section is not yet completed.)
Please let me know if there's anything lacking!
Thank you.