Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(zh): add translation for @pinia/nuxt.ModuleOptions to avoid 404 #2312

Merged
merged 4 commits into from Jul 18, 2023
Merged

docs(zh): add translation for @pinia/nuxt.ModuleOptions to avoid 404 #2312

merged 4 commits into from Jul 18, 2023

Conversation

ifshizuku
Copy link
Contributor

@ifshizuku ifshizuku commented Jul 16, 2023

  • add translation for @pinia/nuxt.ModuleOptions to avoid 404
  • with some other fix translation in Module: pinia

with some other fix translation in Module: pinia
@netlify
Copy link

netlify bot commented Jul 16, 2023

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 02bf8b0
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/64b53f53f9155b0008375560
😎 Deploy Preview https://deploy-preview-2312--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@posva posva added the 📚 docs Related to documentation changes label Jul 16, 2023
@ifshizuku
Copy link
Contributor Author

By the way, i think the repo should have the formatter config for the Markdown file while many IDE will reformat them lead to make additional diff.

@KimYangOfCat
Copy link
Contributor

@ifshizuku The formatting of the contents of markdown files is not relevant to this PR, so if you want to add relevant configurations, please create a new issue to discuss or a new PR to provide a viable solution. So can you remove the changes about formatting associated with the last commit?

@ifshizuku
Copy link
Contributor Author

@ifshizuku The formatting of the contents of markdown files is not relevant to this PR, so if you want to add relevant configurations, please create a new issue to discuss or a new PR to provide a viable solution. So can you remove the changes about formatting associated with the last commit?

@KimYangOfCat I'll do it later

@ifshizuku
Copy link
Contributor Author

ifshizuku commented Jul 17, 2023

@KimYangOfCat The L1202 of the module pinia seem to be the same but it also show in diff, please check it again, thanks. or should i rebase the whole branch to remove the format issued commit from history... maybe reopen a PR is better, sorry for that.

@KimYangOfCat
Copy link
Contributor

KimYangOfCat commented Jul 18, 2023

it‘s OK,I checked the Files Changed of this PR,I think It’s OK,the rebase shouldn't be a problem if this PR will be Squash Merged.
Thank you for your contribution. @ifshizuku
so LGTM @posva

@posva posva merged commit f046d34 into vuejs:v2 Jul 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Related to documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants