Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): intersect __VLS_slots with __VLS_ctx.$slots #5083

Merged
merged 12 commits into from
Feb 12, 2025

Conversation

KazariEX
Copy link
Member

fix #5082

Copy link

pkg-pr-new bot commented Dec 24, 2024

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5083

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5083

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5083

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5083

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5083

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5083

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5083

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5083

commit: b57b57f

@KazariEX KazariEX changed the title fix(language-core): intersect local $slots with __VLS_ctx.$slots fix(language-core): intersect __VLS_slots with __VLS_ctx.$slots Dec 24, 2024
… fix/dollar-slots-type
… fix/dollar-slots-type
@romansp
Copy link

romansp commented Feb 5, 2025

Is there anything we can do to help with merging this PR and hopefully getting a new version of vue-tsc?

Related issue is currently blocking from upgrading to vue-tsc@2.2.0 and typescript@5.7.3.

… fix/dollar-slots-type
@KazariEX KazariEX merged commit 81dec4a into vuejs:master Feb 12, 2025
5 checks passed
@KazariEX KazariEX deleted the fix/dollar-slots-type branch February 12, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slots type resolution is broken in 2.2.0
2 participants