Skip to content

fix(language-core): avoid generic type loss due to destructured props #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

KazariEX
Copy link
Member

@KazariEX KazariEX commented Sep 6, 2024

fix #4820

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband
Copy link

pkg-pr-new bot commented Sep 6, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4821

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4821

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4821

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4821

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4821

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4821

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4821

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4821

commit: 71d1431

KazariEX and others added 7 commits September 7, 2024 00:26

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 904167f into vuejs:master Sep 6, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/issue-4820 branch September 6, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not unwrapping DistributeRef<> for destructed props
2 participants