Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are some issues with type hints #1187

Closed
cj0x39e opened this issue Apr 14, 2022 · 2 comments
Closed

There are some issues with type hints #1187

cj0x39e opened this issue Apr 14, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@cj0x39e
Copy link

cj0x39e commented Apr 14, 2022

image

Visual Studio Code: 1.66.2
Volar version: v0.34.6

Earlier versions did not have this problem, eg 0.33.10.
@johnsoncodehk
Copy link
Member

I can't reproduce this problem in https://github.com/johnsoncodehk/volar-starter, could you provide minimal reproduction?

@cj0x39e
Copy link
Author

cj0x39e commented Apr 16, 2022 •
edited
Loading

I found the reason, when the value of the strictNullChecks option in tsconfig.json is false, there will be this prompt.

reproduction: https://github.com/cj0x39e/volar-issue

@johnsoncodehk johnsoncodehk added bug Something isn't working and removed need info labels Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cj0x39e @johnsoncodehk