Skip to content

fix(no-setup-props-reactivity-loss): report template literal #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix(no-setup-props-reactivity-loss): report template literal #2489

merged 2 commits into from
Jul 2, 2024
+60 −3

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Jun 29, 2024

Keen for feedback 🫡 , fix #2470

waynzh added 2 commits June 29, 2024 15:51
@waynzh
fix(no-setup-props-reactivity-loss): report template literal

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 09541BBFF0C4C795
Learn about vigilant mode
d4cb2c3
@waynzh
test: add template string valid case

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
674a4bb
@waynzh waynzh changed the title Fix/report template literal fix(no-setup-props-reactivity-loss): report template literal Jun 29, 2024
ota-meshi
ota-meshi approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you a lot!

@ota-meshi ota-meshi requested a review from FloEdelmann June 30, 2024 00:47
FloEdelmann
FloEdelmann approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ota-meshi ota-meshi merged commit cac8167 into vuejs:master Jul 2, 2024
18 checks passed
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann

@ota-meshi ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-setup-props-reactivity-loss should report template string expressions
3 participants
@waynzh @FloEdelmann @ota-meshi