Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix require-toggle-inside-transition should respect "<slot>", "v-bind:key", attribute "appear" #2303

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Fix require-toggle-inside-transition should respect "<slot>", "v-bind:key", attribute "appear" #2303

merged 3 commits into from
Oct 27, 2023

Conversation

DevilTea
Copy link
Contributor

fix: #2302

Also, the following case that tansition with attribute appear should be valid.

<template>
  <Transition appear>
    <div />
  </Transition>
</template>

ota-meshi
ota-meshi requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

lib/rules/require-toggle-inside-transition.js Show resolved Hide resolved
ota-meshi
ota-meshi approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 5fc47e5 into vuejs:master Oct 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/require-toggle-inside-transition false positives
2 participants
@DevilTea @ota-meshi