Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace typeParameters with typeArguments #2292

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: replace typeParameters with typeArguments #2292

merged 1 commit into from
Oct 6, 2023

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Oct 6, 2023

FloEdelmann
FloEdelmann approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good from my side. I think we should release this as a patch version as soon as possible.

ota-meshi
ota-meshi approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't notice it.

@ota-meshi
Copy link
Member

I looked into why the test is not currently failing. It appears that the deprecated typeParameters property is still left as an alias on those nodes. Therefore, there is no need to rush patch releases.
However, I haven't released this plugin recently, so I would like to check the remaining PRs and recent issues and release it soon.

@ota-meshi ota-meshi merged commit 8ba6d9a into vuejs:master Oct 6, 2023
15 checks passed
@KaelWD
Copy link
Contributor Author

KaelWD commented Oct 7, 2023

It floods the terminal with depreciation notices in my project, idk why it doesn't here.

@ota-meshi
Copy link
Member

Isn't that a warning about ESLint v9? If so, we support the old ESLint and cannot simply replace it. I have a number of plugins that have similar issues, so I'm considering whether to create a util package for them.

@KaelWD
Copy link
Contributor Author

KaelWD commented Oct 7, 2023

No it's from typescript-eslint 6

@ota-meshi
Copy link
Member

Oh really. I've never seen it so I don't know.

@KaelWD KaelWD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KaelWD @ota-meshi @FloEdelmann