Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert defineOptions after import declarations in vue/prefer-define-options #2275

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Insert defineOptions after import declarations in vue/prefer-define-options #2275

merged 5 commits into from
Oct 11, 2023

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented Aug 15, 2023

closes #2263

FloEdelmann
FloEdelmann approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

ota-meshi
ota-meshi requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Thank you for this PR.

lib/rules/prefer-define-options.js Outdated Show resolved Hide resolved
@ItMaga ItMaga requested a review from ota-meshi October 10, 2023 08:05
ota-meshi
ota-meshi approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 15b99af into vuejs:master Oct 11, 2023
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-define-options should insert defineOptions after import expressions
3 participants
@ItMaga @FloEdelmann @ota-meshi