Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vue/component-tags-order to vue/block-order #2222

Merged
merged 9 commits into from
Jul 29, 2023

Conversation

FloEdelmann
Copy link
Member

Fixes #2214.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@FloEdelmann FloEdelmann requested a review from ota-meshi June 22, 2023 11:22
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. I am busy with office work.
The pull request change looks good to me! However, it seems to change the configuration, so I will merge it when we start working on v10.

@FloEdelmann
Copy link
Member Author

It should not be a breaking change though, I only renamed the rule and followed the deprecation procedure. The breaking change would be to remove the old rule completely.

@ota-meshi
Copy link
Member

ota-meshi commented Jul 2, 2023

In my opinion adding a rule to a shared configuration is marked as a breaking change. (It's not a breaking change if we reduce the rules)

https://github.com/eslint/eslint#semantic-versioning-policy:~:text=eslint%3Arecommended%20is%20updated%20and%20may%20result%20in%20new%20linting%20errors%20(e.g.%2C%20rule%20additions%2C%20most%20rule%20option%20updates)

Users using shared configuration and turning off the vue/component-tags-order rule will receive the new warning unless they turn off the vue/block-order rule.

It's not a breaking change if we don't add vue/block-order to the shareable config.

@FloEdelmann
Copy link
Member Author

Ok, should I then add the (deprecated) vue/component-tags-order rule back to the recommended configs and remove vue/block-order from the configs for now? We should then change it when we remove the vue/component-tags-order rule completely.

@ota-meshi
Copy link
Member

Ok, should I then add the (deprecated) vue/component-tags-order rule back to the recommended configs and remove vue/block-order from the configs for now?

Yes. I think we need to do that to release this PR with v9 👍

@FloEdelmann FloEdelmann marked this pull request as draft July 18, 2023 15:10
@FloEdelmann FloEdelmann marked this pull request as ready for review July 26, 2023 14:17
@FloEdelmann FloEdelmann requested a review from ota-meshi July 26, 2023 14:18
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 7c63e1e into master Jul 29, 2023
@ota-meshi ota-meshi deleted the rename-component-tags-order branch July 29, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename vue/component-tags-order to vue/block-order
2 participants