-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename vue/component-tags-order
to vue/block-order
#2222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. I am busy with office work.
The pull request change looks good to me! However, it seems to change the configuration, so I will merge it when we start working on v10.
It should not be a breaking change though, I only renamed the rule and followed the deprecation procedure. The breaking change would be to remove the old rule completely. |
In my opinion adding a rule to a shared configuration is marked as a breaking change. (It's not a breaking change if we reduce the rules) Users using shared configuration and turning off the It's not a breaking change if we don't add |
Ok, should I then add the (deprecated) |
Yes. I think we need to do that to release this PR with v9 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Fixes #2214.