Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rules incompatible with ESLint v8.40. #2147

Merged
merged 1 commit into from
May 7, 2023
Merged

Conversation

ota-meshi
Copy link
Member

I looked into #2145 and found that the CI #2145 test was failing due to rules not compatible with ESLint v8.40.
This PR fixes that issue.

Verified

This commit was signed with the committer’s verified signature.
setchy Adam Setch
@ota-meshi ota-meshi requested a review from FloEdelmann May 6, 2023 23:16
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual change looks fine, but I have one question.

@ota-meshi ota-meshi merged commit 7215073 into master May 7, 2023
@ota-meshi ota-meshi deleted the fix-for-eslint-8.40 branch May 7, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants