Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added array-element-newline rule from eslint #2066

Merged
merged 3 commits into from
Dec 25, 2022

Conversation

alshyra
Copy link
Contributor

@alshyra alshyra commented Dec 22, 2022

Hello,
I'm currently using eslint-plugin-vue and it works great !
Even though it's not advised we depends exclusively on eslint for code style and format.

There is one rule in template I'd like to see: https://eslint.org/docs/latest/rules/array-element-newline that why I propose to you this pull request.

I've read the https://eslint.vuejs.org/developer-guide/ but this is my first pull request so let me know if I miss something.

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I only got small remarks regarding the test cases.

tests/lib/rules/array-element-newline.js Outdated Show resolved Hide resolved
tests/lib/rules/array-element-newline.js Outdated Show resolved Hide resolved
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now :)

Thanks!

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 89fb2fe into vuejs:master Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants