Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding-lines-in-component-definition rule #2052

Merged

Conversation

ItMaga
Copy link
Contributor

@ItMaga ItMaga commented Dec 1, 2022

This PR adds padding-lines-in-component-definition rule that requires or disallows padding lines in component definition.

close #1817

@ota-meshi
Copy link
Member

Thank you for this PR! I would love to check this PR, but right now I am busy and don't have time to do it. So please wait 🙏

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. Sorry for the delay in checking.
It looks pretty good to me, but I have a few requests.

lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
@ItMaga ItMaga requested a review from ota-meshi January 7, 2023 23:28
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing this PR! I have one request.

lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
@ItMaga ItMaga requested a review from ota-meshi January 10, 2023 14:54
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I just have some very minor improvement requests, then this is good to go!

lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
lib/rules/padding-lines-in-component-definition.js Outdated Show resolved Hide resolved
@ItMaga
Copy link
Contributor Author

ItMaga commented Jan 11, 2023

@FloEdelmann Thank you for feedback! All conversations were resolved 

@FloEdelmann FloEdelmann merged commit 5e0bd2c into vuejs:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: padding-line-between-component-options
3 participants