- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 681
Add padding-lines-in-component-definition
rule
#2052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add padding-lines-in-component-definition
rule
#2052
Conversation
Thank you for this PR! I would love to check this PR, but right now I am busy and don't have time to do it. So please wait 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. Sorry for the delay in checking.
It looks pretty good to me, but I have a few requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for changing this PR! I have one request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I just have some very minor improvement requests, then this is good to go!
@FloEdelmann Thank you for feedback! All conversations were resolved |
This PR adds
padding-lines-in-component-definition
rule that requires or disallows padding lines in component definition.close #1817