Add vue/no-v-text rule
#1605
Add vue/no-v-text rule
#1605
Conversation
docs/rules/no-v-text.md
Outdated
| sidebarDepth: 0 | ||
| title: vue/no-v-text | ||
| description: disallow use of v-text | ||
| since: v7.17.0 |
There was a problem hiding this comment.
"since" is set automatically at release. So for now remove it.
docs/rules/no-v-text.md
Outdated
|
|
||
| - :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule. | ||
|
|
||
| - However, when using selfClose to element with v-text like `<div v-text="foobar" />`, it can't be fixed. |
There was a problem hiding this comment.
The header part is automatically generated, so the autofix sentence may not come to the bottom in the future. Could you list it in another place.
lib/rules/no-v-text.js
Outdated
| if (!vText.value) return | ||
| if (vText.value.type !== 'VExpressionContainer') return | ||
| if (!vText.value.expression) return | ||
| if (vText.value.expression.type !== 'Identifier') return |
There was a problem hiding this comment.
Why limit it to an Identifier? I think all expressions should be reported.
There was a problem hiding this comment.
It's my misunderstood.
I don't know how to use v-text very much.
I'm going to fix it.
There was a problem hiding this comment.
I can use utils.getDirective!!!
lib/rules/no-v-text.js
Outdated
| node: vText.node, | ||
| loc: vText.loc, | ||
| message: "Don't use 'v-text'.", | ||
| fix(fixable) { |
There was a problem hiding this comment.
I think autofix is very difficult. For example, converting the following expression to {{}} will result in a parse error in Vue2.
<div v-text="'</div>'"></div>↓
<div >{{'</div>'}}</div>So if you want to implement autofix, we need to limit autofix by the content of the expression.
Or I think it's good not to implement autofix.
There was a problem hiding this comment.
I make sense of what there are some points that I have to think about.
Yeah. I agree with your mention point.
I will remove the fix function from this rule.
close #1435
Add rule
vue/no-v-text.