feat(overlay): add credentialless
attribute for iframe
#614
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the WASM module to generate image previews, I faced some errors with showing iframe after setting this parameters to
server
insidevite.config.js
The fix for this was setting the
credentialless
attribute for all iframe; I think that we should add this to ouroverlay/iframe
, too.Chrome Blog: link
Video Example:
https://github.com/user-attachments/assets/2fbce091-91fd-4fad-a948-7e24f081a0a9