Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applet): intergration ui package's unocss style #598

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

alexzhang1030
Copy link
Member

Currently, we highly depend on unocss, so we didn’t anticipate that someone would use @vue/devtools-applet without also using unocss. That causes the class names of devtool-ui to not be extracted.

Verified

This commit was signed with the committer’s verified signature.
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 1b8b8ae
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66d81c0b665dab0008cceec7

Copy link

pkg-pr-new bot commented Sep 4, 2024

Open in Stackblitz

@vue/devtools

pnpm add https://pkg.pr.new/@vue/devtools@598

@vue/devtools-core

pnpm add https://pkg.pr.new/@vue/devtools-core@598

@vue/devtools-api

pnpm add https://pkg.pr.new/@vue/devtools-api@598

@vue/devtools-kit

pnpm add https://pkg.pr.new/@vue/devtools-kit@598

vite-plugin-vue-devtools

pnpm add https://pkg.pr.new/vite-plugin-vue-devtools@598

commit: 1b8b8ae

@webfansplz webfansplz changed the title fix(applet): should import bundled unocss of ui package fix(applet): intergration ui package's unocss style Sep 4, 2024
@webfansplz webfansplz merged commit b89e6c0 into vuejs:main Sep 4, 2024
7 checks passed
@alexzhang1030 alexzhang1030 deleted the chore/applet-style branch September 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants