Skip to content

fix(client): hide action list on editing for state-field editor #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

KurumiRin
Copy link
Contributor

@KurumiRin KurumiRin commented Jul 8, 2024

The list of actions still exists while in the editing state, causing actions such as deletion of currently edited data to result in unintended data errors. So I think hiding the action list in edit state but showing the preview of the data before editing might be a better ui presentation while avoiding data errors.

This pr will fix #512
Might be a better solution for #507

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 17918e1
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/668f377368667e0008208532

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@KurumiRin
Copy link
Contributor Author

CleanShot 2024-07-09 at 14 00 51
The preview and copy behaviors of the original data can be preserved, so as to avoid data errors that may be caused by keeping the action buttons in the editing mode, as well as to be as consistent as possible with the previous ui design.

@webfansplz webfansplz requested a review from alexzhang1030 July 11, 2024 00:12

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
@webfansplz webfansplz changed the title fixed data errors caused by deleting data being edited fix(client): hide action list on editing for state-field editor Jul 11, 2024
@webfansplz webfansplz merged commit c3d4464 into vuejs:main Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting data in an edited state can lead to data clutter.
3 participants