Skip to content

fix(client): reposition dockingPanel dropdown on window resize #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2024
Merged

fix(client): reposition dockingPanel dropdown on window resize #479

merged 4 commits into from
Jun 28, 2024

Conversation

LukerSpringtree
Copy link
Contributor

@LukerSpringtree LukerSpringtree commented Jun 24, 2024

Closes #478

2024-06-25.01.09.57.mov

陆德靖 and others added 4 commits June 14, 2024 02:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 3546201
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/6679abda58e1d80008810b9f

@LukerSpringtree LukerSpringtree changed the title Fix to #478 fix(client): Fix to #478 Jun 24, 2024
@alexzhang1030
Copy link
Member

When distance has changed, the position will re-calculate, you can swap 6 and 6.01 for the same user experience when the container has resized(by useResizeObserver and useDebounceFn)

image

@alexzhang1030 alexzhang1030 changed the title fix(client): Fix to #478 fix(client): dockingPanel dropdown incorrect pos after resize Jun 25, 2024
@LukerSpringtree
Copy link
Contributor Author

2024-06-25.16.25.49.mov

I don't think this is a good expression.

@LukerSpringtree
Copy link
Contributor Author

LukerSpringtree commented Jun 25, 2024

2024-06-25.16.25.49.mov
I don't think this is a good expression.

The dropdown position will be delayed.

@alexzhang1030

@alexzhang1030
Copy link
Member

Agree with you... Not a smooth UX like yours, but a better solution, we should let floating-vue calc the real position instead of a hardcode distance...

Would you mind to find a better solution?

@LukerSpringtree
Copy link
Contributor Author

Agree with you... Not a smooth UX like yours, but a better solution, we should let floating-vue calc the real position instead of a hardcode distance...

Would you mind to find a better solution?

next time!

Can you merge it, please!

@LukerSpringtree
Copy link
Contributor Author

Anyway, my solution is better than the current situation. You can optimize it later

@alexzhang1030

@webfansplz webfansplz changed the title fix(client): dockingPanel dropdown incorrect pos after resize fix(client): reposition dockingPanel dropdown on window resize Jun 28, 2024
@webfansplz webfansplz merged commit 37f2de6 into vuejs:main Jun 28, 2024
5 checks passed
@LukerSpringtree
Copy link
Contributor Author

I had a lot of ideas and enthusiasm about this project, but because of this PR, I felt a little uncomfortable.
That's probably why open source is so hard.

@webfansplz
Copy link
Member

I had a lot of ideas and enthusiasm about this project, but because of this PR, I felt a little uncomfortable. That's probably why open source is so hard.

First, thank you very much for your contributions to the project. We greatly appreciate and welcome everyone's contributions. I understand it's normal to have different views on technical matters. We've had constructive discussions and have tried to accept PRs wherever possible. So, what specifically made you uncomfortable?

@LukerSpringtree
Copy link
Contributor Author

I had a lot of ideas and enthusiasm about this project, but because of this PR, I felt a little uncomfortable. That's probably why open source is so hard.

First, thank you very much for your contributions to the project. We greatly appreciate and welcome everyone's contributions. I understand it's normal to have different views on technical matters. We've had constructive discussions and have tried to accept PRs wherever possible. So, what specifically made you uncomfortable?

Let me wait too long. hhh~

Thank you for your reply, I will continue to mention pr. haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: when we change the expandSidebar there will be a bug.
3 participants