Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue2's dependencies are outdated #408

Open
baboon-king opened this issue Dec 20, 2023 · 6 comments
Open

Vue2's dependencies are outdated #408

baboon-king opened this issue Dec 20, 2023 · 6 comments
Labels

Comments

@baboon-king
Copy link

this's package.json form npm create vue@legacy

{
  "name": "xxxx-xxxx-xxxx",
  "version": "0.0.0",
  "scripts": {
    "dev": "vite",
    "build": "run-p type-check build-only",
    "preview": "vite preview --port 4173",
    "test:unit": "vitest --environment jsdom",
    "build-only": "vite build",
    "type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false",
    "lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --fix --ignore-path .gitignore"
  },
  "dependencies": {
    "pinia": "^2.0.16",
    "vue": "^2.7.7",
    "vue-router": "^3.5.4"
  },
  "devDependencies": {
    "@rushstack/eslint-patch": "^1.1.0",
    "@types/jsdom": "^16.2.14",
    "@types/node": "^16.11.45",
    "@vitejs/plugin-legacy": "^2.0.0",
    "@vitejs/plugin-vue2": "^1.1.2",
    "@vitejs/plugin-vue2-jsx": "^1.0.2",
    "@vue/eslint-config-prettier": "^7.0.0",
    "@vue/eslint-config-typescript": "^11.0.0",
    "@vue/test-utils": "^1.3.0",
    "@vue/tsconfig": "^0.1.3",
    "eslint": "^8.5.0",
    "eslint-plugin-vue": "^9.0.0",
    "jsdom": "^20.0.0",
    "npm-run-all": "^4.1.5",
    "prettier": "^2.5.1",
    "terser": "^5.14.2",
    "typescript": "~4.7.4",
    "vite": "^3.0.2",
    "vitest": "^0.18.1",
    "vue-template-compiler": "^2.7.7",
    "vue-tsc": "^0.38.8"
  }
}

it's create-vue@2.2.0
His last update was a year ago.

The main point is:

  1. node 16 is outdate
  2. The latest "vite" is v5.
@cexbrayat cexbrayat added the vue2 label Dec 20, 2023
@cexbrayat
Copy link
Member

Hi @baboon-king

As Vue 2 is officially end of life (see https://blog.vuejs.org/posts/vue-2-eol), I think most contributors like myself spend their free time fixing the issues with Vue 3 in priority.

If you feel like it, feel free to open a PR to fix this and we'll gladly review it and merge it!

@baboon-king
Copy link
Author

As Vue 2 is officially end of life ....

First of all! Thank you for your reply.

I'll try it. It will start soon.

@baboon-king
Copy link
Author

@cexbrayat
Hi! Excuse me.

I've read the codes.

Because this repository doesn't have a Contribution Guide

Before starting to work, if you can briefly explain how it works or what I need to pay attention to.

This will help me do this better.

Thanks!😃

@cexbrayat
Copy link
Member

I never contributed to the Vue 2 version so I don't know if I can really help, but here is what I know:

Make sure that all the tests are successful locally and you can then open a PR 👍
Maybe start with small changes first (node 16 or Vue 2 version for example). Then you can take a look at what we did for Vite v5 on the main branch.

@baboon-king
Copy link
Author

I never contributed to the Vue 2 version so I don't know if I can.....

Thank you very much 🙏.

These have been tips very informative. Thank you.

@baboon-king
Copy link
Author

@cexbrayat
"Excuse me, I've made progress🥳. Could you please review it?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants