Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): render initial selected properly #9442

Merged
merged 5 commits into from
Oct 20, 2023
Merged

fix(ssr): render initial selected properly #9442

merged 5 commits into from
Oct 20, 2023

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Oct 20, 2023 •
edited

close #9440
BTW, support optgroup

@pikax
Copy link
Member

pikax commented Oct 20, 2023

@edison1105 test pls 🙏

@pikax pikax added the 🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. label Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB 32.7 kB 29.5 kB
vue.global.prod.js 132 kB 49.3 kB 44.3 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 50.7 kB 20 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@edison1105
Copy link
Member Author

@pikax done

@pikax
Copy link
Member

pikax commented Oct 20, 2023

there's this warning
image

https://deploy-preview-9442--vue-sfc-playground.netlify.app/#__SSR__eNqNVMlu2zAQ/RVCF6eAJSINejGUIG2RQwp0QV30UvWgSGObqUQS5EhxIejfOyQlm3GTIPBFnDfLm+V5SN5rnfUdJKskt5URGpkF7PRVIUWrlUE2MAMbNrKNUS1bkOviAK2hgQpvpe5wgjMe2Vxecna/SknrMjsM6q8ahZLs0mU+W0yv88Wb2U95iyWHX0d0yebvt4vfIWvOA2UiSw+EVjclAr0Yy3fnV8NwWnEcc06AdwhQKjz7Pm1VDc1lkTyOKBLWlHceCI0xq1rAnZDbIvF5KFOgSzk2ypDj9BRy7oOS9CnCHg8gxeY8fAYyPGZDppwfukmWSRh32pY6u7dK0q4GF1VMABVYMW9xNhq6exfJDlHbFedVLSmMuhO9ySQgl7rl1+TGTSdRtJDWqr2+yC6yd7wWFmNzBrZN74x6sGAoSZEsozJE2vRgUgOyBgPmtWVPwuLSJ9B/5V31sZAjDQUtHctGbE9GUqlWiwZM2N/j0ZRNox4+eRuaDg69VDuo/jxhv7f70NM3A55Z1D+WZgsY4Jv1F9puBNIxdc20hmfA72BV04VjcG4fOlkT7cjPs731G6Zz+2Fv9gjSzk05on4a3t/v4+MLrR/p0rSjKZ7I9Ym/gVmUXiA/y6YD0mUNGyHhszOdDfhXw4qt0RDNkUT8sjBr0c/CCUcfie9Y46Au59Yo5HPMpJRJNiFZrJbxH7jOplw=

@edison1105
Copy link
Member Author

@pikax This is a playground problem, there is no problem locally. This is probably because runtime and ssr use the same currentInstance in the playground.

pikax
pikax reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pikax pikax mentioned this pull request Oct 20, 2023
Open
@yyx990803 yyx990803 merged commit cdb2e72 into vuejs:main Oct 20, 2023
11 checks passed
yyx990803 pushed a commit that referenced this pull request Oct 21, 2023
@edison1105 @yyx990803
fix(compiler-ssr): fix ssr compile error for select with non-option c…
9dbff73 
…hildren (#9442)

fix #9440
lumozx pushed a commit to lumozx/core that referenced this pull request Oct 21, 2023
@edison1105 @lumozx
fix(compiler-ssr): fix ssr compile error for select with non-option c…
fcf7e50 
…hildren (vuejs#9442)

fix vuejs#9440
@danielroe danielroe mentioned this pull request Oct 22, 2023
Closed
sxzz pushed a commit that referenced this pull request Oct 23, 2023
@edison1105 @sxzz
fix(compiler-ssr): fix ssr compile error for select with non-option c…
4fbd6e2 
…hildren (#9442)

fix #9440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax left review comments

Assignees
No one assigned
Labels
🔥 p5-urgent Priority 5: this fixes build-breaking bugs that affect most users and should be released ASAP. regression
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSR Rendering of select input with slot is breaking
3 participants
@edison1105 @pikax @yyx990803