fix(compiler-sfc): normalize windows paths when resolving types #8671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
added
🐞 bug
sxzz
approved these changes
Aug 12, 2023
sodatea
added
❗ p4-important
sodatea
requested changes
Oct 19, 2023
| @@ -778,7 +778,7 @@ function importSourceToScope( | |||
| if (!resolved) { | |||
| if (source.startsWith('.')) { | |||
| // relative import - fast path | |||
| const filename = joinPaths(scope.filename, '..', source) | |||
| const filename = joinPaths(normalizePath(scope.filename), '..', normalizePath(source)) | |||
There was a problem hiding this comment.
Tested on Windows and this does not fix the bug. The problem here is the ...
yyx990803
added
❗ p4-important
sodatea
added a commit
to sodatea/core
that referenced
this pull request
Oct 20, 2023
Closes vuejs#8671 Closes vuejs/vue-loader#2048 `dirname` is the safest way to get a directory name from a path string. As for this specific bug, it's because `path.posix.join(AnyWindowsPath, '..')` returns `.`. I'm not sure whether there will be unexpected regression if I modify the `joinPaths` utility, so I changed the smallest possible bit of code to fix this.
|
Closing in favor of #9446 |
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
yyx990803
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting error when using defineProps and importing a type from another files on Windows.
For more information and a reproduction repository, look at this issue
Similar to this pull request