Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v-model Modifiers trim/number did not work if use hyphenate string in props and camelize in emits, or reverse #4848

Closed
zhaozhongyu opened this issue Oct 25, 2021 · 1 comment · Fixed by #9609
Closed

v-model Modifiers trim/number did not work if use hyphenate string in props and camelize in emits, or reverse #4848

zhaozhongyu opened this issue Oct 25, 2021 · 1 comment · Fixed by #9609
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem 🐞 bug Something isn't working scope: v-model

Comments

@zhaozhongyu
Copy link

Version

3.2.20

Reproduction link

sfc.vuejs.org/

Steps to reproduce

see message

What is expected?

trim modifier work

What is actually happening?

trim modifier did not work

image
@posva posva added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working has workaround A workaround has been found to avoid the problem labels Oct 25, 2021
@posva
Copy link
Member

posva commented Oct 25, 2021 •
edited
Loading

Use the camelCase version v-model:msgTest as a workaround (will not work in HTML templates, e.g. outside vue files)

It also looks like the modifiers are being passed as attributes (kebab or camel case):

<div id="app" data-v-app=""><h1>testtttt</h1><h2 msgtestmodifiers="[object Object]">beforetestttttafter</h2></div>

@zhaozhongyu zhaozhongyu mentioned this issue Oct 25, 2021
Closed
@skirtles-code skirtles-code mentioned this issue Nov 15, 2023
Merged
yyx990803 added a commit that referenced this issue Jul 13, 2024
@skirtles-code @yyx990803
fix(v-model): component v-model modifiers trim and number when cases …

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
7fb6eb8 
…don't match (#9609)

close #4848
close #4850 (based on commits from #4850)

Co-authored-by: zhaozhongyu <zhaozhongyu@xunlei.com>
Co-authored-by: Evan You <evan@vuejs.org>
jacobfogolyan pushed a commit to jacobfogolyan/vuejs-core that referenced this issue Jul 13, 2024
@skirtles-code @yyx990803 @jacobfogolyan
fix(v-model): component v-model modifiers trim and number when cases …

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
3a5ea9b 
…don't match (vuejs#9609)

close vuejs#4848
close vuejs#4850 (based on commits from vuejs#4850)

Co-authored-by: zhaozhongyu <zhaozhongyu@xunlei.com>
Co-authored-by: Evan You <evan@vuejs.org>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. has workaround A workaround has been found to avoid the problem 🐞 bug Something isn't working scope: v-model
Projects
None yet
Milestone
No milestone
3 participants
@posva @haoqunjiang @zhaozhongyu