Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KeepAlive): avoid cache suspense comment root #11479

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Aug 2, 2024

close #6028

@edison1105
Copy link
Member Author

/ecosystem-ci run

Copy link

github-actions bot commented Aug 2, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.1 kB (+35 B) 34.5 kB (+10 B) 31.1 kB (-23 B)
vue.global.prod.js 147 kB (+35 B) 54 kB (+8 B) 48 kB (-2 B)

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 20.9 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.2 kB (+35 B) 24.5 kB (+9 B) 22.3 kB (+51 B)

@vue-bot
Copy link
Contributor

vue-bot commented Aug 2, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 added scope: keep-alive scope: suspense 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Aug 2, 2024
@yyx990803 yyx990803 merged commit a917c05 into vuejs:main Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: keep-alive scope: suspense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In router-view, the page browser rendered by suspense wrapped by keepAlive cannot return or switch components
3 participants