refactor: simplify traverse() for deep watchers #10795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic in
traverse()
. It should also shave a few bytes off the bundle.The current implementation of
traverse()
takes two numbers, thedepth
and thecurrentDepth
. The function calls itself recursively, incrementingcurrentDepth
at each stage and then comparing that todepth
.But there's no need to use two numbers. Just one is enough. Each recursion can just decrement
depth
and then check whether it is still greater than 0.For
deep: true
, adepth
value ofInfinity
can be used, rather than trying to handle it specially.The current depth logic was originally introduced in #9928, partly in preparation for adding #9572. While my proposed changes will introduce small conflicts with that second PR, I believe they are easily fixable, just by treating
deep: true
asdeep: Infinity
.