Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): fix option selected update failed #10200

Merged
merged 2 commits into from Feb 6, 2024
Merged

fix(runtime-dom): fix option selected update failed #10200

merged 2 commits into from Feb 6, 2024

Conversation

Doctor-wu
Copy link
Contributor

@Doctor-wu Doctor-wu commented Jan 24, 2024 •
edited

These codes are introduced by 2ffb956 and it's the edge perf.
So I think it's ok to delete it to prevent the options from skipping updates.

close #10194

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.2 kB (-17 B) 34.3 kB (-11 B) 30.9 kB (-5 B)
vue.global.prod.js 147 kB (-18 B) 53.6 kB (-11 B) 47.9 kB (+109 B)

Usages

Name Size Gzip Brotli
createApp 50.3 kB 19.7 kB 18 kB
createSSRApp 53.7 kB 21 kB 19.1 kB
defineCustomElement 52.6 kB 20.4 kB 18.6 kB
overall 64 kB 24.8 kB 22.5 kB

@Doctor-wu Doctor-wu changed the title fix(runtime-dom): fix option selected update fix(runtime-dom): fix option selected update failed Jan 24, 2024
@edison1105 edison1105 mentioned this pull request Feb 5, 2024
Closed
@yyx990803 yyx990803 merged commit f31d782 into vuejs:main Feb 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.4.15 regression on v-model in <select>
3 participants
@Doctor-wu @LinusBorg @yyx990803