Skip to content

Commit ad14b2d

Browse files
authoredSep 11, 2024··
fix: missing colon in event name for dynamic model arguments (#642)
1 parent 8de3f20 commit ad14b2d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎packages/babel-plugin-jsx/src/transform-vue-jsx.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ const buildProps = (path: NodePath<t.JSXElement>, state: State) => {
208208
}
209209

210210
const updateName = isDynamic
211-
? t.binaryExpression('+', t.stringLiteral('onUpdate'), propName)
211+
? t.binaryExpression('+', t.stringLiteral('onUpdate:'), propName)
212212
: t.stringLiteral(
213213
`onUpdate:${
214214
(propName as t.StringLiteral)?.value || 'modelValue'

‎packages/babel-plugin-jsx/test/__snapshots__/snapshot.test.ts.snap

+5-5
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ const b = {
269269
};
270270
_createVNode(_Fragment, null, [_createVNode(_resolveComponent("A"), {
271271
[foo]: xx,
272-
["onUpdate" + foo]: $event => xx = $event
272+
["onUpdate:" + foo]: $event => xx = $event
273273
}, null, 16), _createVNode(_resolveComponent("B"), {
274274
"modelValue": xx,
275275
"modelModifiers": {
@@ -281,25 +281,25 @@ _createVNode(_Fragment, null, [_createVNode(_resolveComponent("A"), {
281281
[foo + "Modifiers"]: {
282282
"a": true
283283
},
284-
["onUpdate" + foo]: $event => xx = $event
284+
["onUpdate:" + foo]: $event => xx = $event
285285
}, null, 16), _createVNode(_resolveComponent("D"), {
286286
[foo === 'foo' ? 'a' : 'b']: xx,
287287
[(foo === 'foo' ? 'a' : 'b') + "Modifiers"]: {
288288
"a": true
289289
},
290-
["onUpdate" + (foo === 'foo' ? 'a' : 'b')]: $event => xx = $event
290+
["onUpdate:" + (foo === 'foo' ? 'a' : 'b')]: $event => xx = $event
291291
}, null, 16), _createVNode(_resolveComponent("E"), {
292292
[a()]: xx,
293293
[a() + "Modifiers"]: {
294294
"a": true
295295
},
296-
["onUpdate" + a()]: $event => xx = $event
296+
["onUpdate:" + a()]: $event => xx = $event
297297
}, null, 16), _createVNode(_resolveComponent("F"), {
298298
[b.c]: xx,
299299
[b.c + "Modifiers"]: {
300300
"a": true
301301
},
302-
["onUpdate" + b.c]: $event => xx = $event
302+
["onUpdate:" + b.c]: $event => xx = $event
303303
}, null, 16)]);"
304304
`;
305305

0 commit comments

Comments
 (0)
Please sign in to comment.