Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed error with no expected value in expandColumnTitle slot #7265

Merged
merged 9 commits into from
Jan 16, 2024

Conversation

cc-hearts
Copy link
Contributor

@cc-hearts cc-hearts commented Jan 10, 2024

replace vue's private renderSlot method with the customRenderSlot method.

what customRenderSlot does is enhance the way jsx is rendered, so that if there is only a Comment or Fragment in the slot, the default content is rendered, in line with what is expected from template rendering.

close #7260

@tangjinzhou
Copy link
Member

用的 renderSlot 的地方都有这个隐患吧,可以全局排查下

@cc-hearts
Copy link
Contributor Author

renderSlot 似乎不是开放的 Api,是不是要考虑 使用默认的 jsx slot 的渲染方式去替换 renderSlot 这个方法?如果可以,我全局都排查改下

@cc-hearts
Copy link
Contributor Author

done

cc-hearts and others added 2 commits January 14, 2024 17:28

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tangjinzhou tangjinzhou merged commit d870f3f into vueComponent:main Jan 16, 2024
@wsxe9988
Copy link

wsxe9988 commented Feb 2, 2024

@cc-hearts 老哥,可以给3.x提个么

@cc-hearts
Copy link
Contributor Author

@cc-hearts 老哥,可以给3.x提个么

已经有 3.x的pr了 。 #7252

@cc-hearts cc-hearts deleted the fix/7260 branch May 30, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

嵌套子表格不兼容vue3.4, 官方文档里的template目前都是会报错的
4 participants