fix tooltip onPopupAlign never called #7112
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have defined
onPopupAlign
function inTooltip
component.But this function will never invoked.
Because the props of
PopupInner
component do not acceptonAlign
prop. We need have to include it.In this way, we can trigger this function from here:
Or we can also remove this part:
// components/tooltip/Tooltip.tsx export default defineComponent({ setup() { - const onPopupAlign = (domNode: HTMLElement, align: any) => {}; const vcTooltipProps = { onPopupAlign, }; return wrapSSR(<VcTooltip {...vcTooltipProps}>{/* ... */}</VcTooltip>); }, });