TextCollectingVisitor works better with code blocks #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call was happening first irrespective of whether the node was a TextContainer so lifted this logic out of the `if` block.
It seems that currently LineBreakNode is independant of TextContainer so it seems safe to pull that out of the `if` block.
Consequently only a single new line is needed to add paragraph breaks
- Removed special case logic for Paragraph blocks - Generalised from BlankLineBreakNode case
Implementation based on Text collectText(..) but using getContentChars()
|
@roxspring, thank you for the PR. I reviewed the changes and will merge it and make a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes, with unit tests where appropriate:
TextCollectingVisitorto avoid duplicate codeTextContainerhas a newcollectEndText(..)method allowingParagraphto append it's optional trailing line breakBlocktext (implicitly includingFencedCodeBlock, no longer relying onParagraphspecial case)IndentedCodeBlockimplementsTextContainerand collects content chars.Closes #574