Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools used in CI #25

Merged
merged 2 commits into from Feb 9, 2023
Merged

Update tools used in CI #25

merged 2 commits into from Feb 9, 2023

Conversation

sandhose
Copy link
Contributor

This updates all the GitHub Actions used in CI, and switches to using maintained actions where possible.

This should fix the coverage job from failing, and remove the warning about the set-output command being deprecated.

I would also suggest removing the beta and nightly jobs from the test matrix to reduce the number of jobs. This currently uses almost 50 jobs, which seems a bit overkill. Dropping those would drop that number to ~20. If you consider that a free personal plan includes 20 concurrent runners for the whole account, this would considerably speed up CI.

@vorner
Copy link
Owner

vorner commented Jan 31, 2023

Hello

I prefer having any CI deps that get a secret pinned to exact version instead of a tag/branch which can change. Would that be a problem to keep it that way (I'm OK with bumping it to a newer version, just taking the exact commit the v3 is at now)?

@sandhose
Copy link
Contributor Author

sandhose commented Feb 1, 2023

I prefer having any CI deps that get a secret pinned to exact version instead of a tag/branch which can change. Would that be a problem to keep it that way (I'm OK with bumping it to a newer version, just taking the exact commit the v3 is at now)?

Makes sense! I did that in 91c186a

@vorner vorner merged commit 2da8eec into vorner:main Feb 9, 2023
@vorner
Copy link
Owner

vorner commented Feb 9, 2023

Thank you (and sorry for the longer response time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants