fix column type conversion in SQLite3 driver #1293
Merged
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the SQLite3 driver related to column type conversion. The issue occurred when a column was not nullable, resulting in incorrect type conversion. Specifically, columns with types such as
FLOAT(2, 1)
orTYNYINT(1)
were wrongly converted to string instead offloat32
andint8
(although these types were correctly converted intonull.Float32
andnull.Int8
when the columns are nullable).In this pull request, I have addressed this issue by fixing the column type conversion logic for non-nullable columns. Now, even if a column is not nullable, the types
FLOAT(2, 1)
andTYNYINT(1)
are correctly converted tofloat32
andint8
, respectively. Additionally, I have updated the relevant test cases to thoroughly verify that these type conversions work as intended.