Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_js no longer compatible with nbconvert / support es modules #1413

Closed
timkpaine opened this issue Oct 31, 2023 · 0 comments
Closed

include_js no longer compatible with nbconvert / support es modules #1413

timkpaine opened this issue Oct 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@timkpaine
Copy link
Member

voila/voila/utils.py

Line 267 in 6418e25

def include_js(template_name: str, base_url: str, name: str) -> str:

This does not allow for es modules, which is now the second argument:
jupyter/nbconvert#2063
@timkpaine timkpaine added the enhancement New feature or request label Oct 31, 2023
@timkpaine timkpaine changed the title include_js no longer compatible with nbconvert include_js no longer compatible with nbconvert / support es modules Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timkpaine