Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Troubleshoot the check release workflow #1208

Merged
merged 2 commits into from Sep 28, 2022
Merged

Troubleshoot the check release workflow #1208

merged 2 commits into from Sep 28, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 27, 2022

References

Another attempt at troubleshooting the CI.

Similar to #1207

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/voila/troubleshoot-ci

@jtpio
Copy link
Member Author

jtpio commented Sep 27, 2022

cc @martinRenou the check release check seems to be passing now with this change.

Suspecting this is related to the bump to node 16 in jupyterlab/maintainer-tools#121.

@jtpio
Copy link
Member Author

jtpio commented Sep 27, 2022 •
edited

This might be related to a new behavior in npm executing the prepare script by default.

We can try removing it from the package.json so it's aligned with the current version of the cookiecutter: https://github.com/jupyterlab/extension-cookiecutter-ts/blob/468cc0b46bb8550a53c33fea60f4e7976e360143/%7B%7Bcookiecutter.python_name%7D%7D/package.json#L31-L56

@jtpio jtpio added this to the 0.3.x milestone Sep 27, 2022
@martinRenou
Copy link
Member

Good catch on this! Thanks @jtpio !

meeseeksdev please backport to 0.3.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 27, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Sep 27, 2022
@jtpio @meeseeksmachine
Backport PR voila-dashboards#1208: Troubleshoot the check release wor…
2b71c31 
…kflow
@martinRenou
Copy link
Member

There seems to be an issue with the ui-tests, I'm currently trying to understand the issue.

@jtpio jtpio marked this pull request as ready for review September 27, 2022 16:53
@jtpio
Copy link
Member Author

jtpio commented Sep 27, 2022

There seems to be an issue with the ui-tests, I'm currently trying to understand the issue.

Alright, this could probably be addressed separately? (for example in #1205?).

@martinRenou
Copy link
Member

Alright, this could probably be addressed separately?

Sure!

martinRenou
martinRenou approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 0d6f6aa into voila-dashboards:main Sep 28, 2022
martinRenou pushed a commit that referenced this pull request Sep 28, 2022
@meeseeksmachine @jtpio
Backport PR #1208: Troubleshoot the check release workflow (#1209)
f43321b 
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@jtpio jtpio deleted the troubleshoot-ci branch September 28, 2022 07:03
@jtpio jtpio mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.3.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @martinRenou