vcsim: add vsan Datastore support #3705
Merged
+413
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougm
force-pushed
the
vcsim-vsan
branch
3 times, most recently
from
62faf31 to
7e07b03
Compare
bryanv
previously approved these changes
Mar 10, 2025
- Use a single top-level TempDir for a vcsim Model instance. Make this path available via OptionManager. This top-level can be used internally as backing for vSAN Datastores. - Split FileManager.resolve logic into Datastore.resolve and use that method everywhere for resolving a Datastore relative path to local file system absolute path. This is where top-level vSAN friendlyName is now translated to vSAN object UUID. - ReconfigureComputeResource_Task will now create a vsanDatastore when spec.VsanConfig.Enabled == true. This Datastore will be added to existing hosts in the cluster, and any hosts later added to the cluster. - HostDatastoreBrowser search methods now populate the FriendlyName field for vSAN Datastores. - The tests added to datastore.bats cover these cases using existing govc commands. Signed-off-by: Doug MacEachern <dougm@broadcom.com>
bryanv
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single top-level TempDir for a vcsim Model instance. Make this path available via OptionManager. This top-level can be used internally as backing for vSAN Datastores.
Split FileManager.resolve logic into Datastore.resolve and use that method everywhere for resolving a Datastore relative path to local file system absolute path. This is where top-level vSAN friendlyName is now translated to vSAN object UUID.
ReconfigureComputeResource_Task will now create a vsanDatastore when spec.VsanConfig.Enabled == true. This Datastore will be added to existing hosts in the cluster, and any hosts later added to the cluster.
HostDatastoreBrowser search methods now populate the FriendlyName field for vSAN Datastores.
The tests added to datastore.bats cover these cases using existing govc commands.