api: add override mechanism for SOAP Header.Cookie #3636
Merged
+102
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
reviewed
Dec 6, 2024
dougm
force-pushed
the
cookie-auth
branch
2 times, most recently
from
be1221b to
3cfeaaa
Compare
Sessions are consumed by API endpoints via one of: - HTTP Cookie (vim25 for example) - HTTP Header (vmodl2 /rest and /api) - SOAP Header (pbm, vslm, sms for example) The soap.Client had always set the SOAP Header cookie regardless if consumed by an API endpoint. Clients must now opt-in to this behavior if they need it, such as pbm and vslm. This also allows clients to change the name of soap.Header.Cookie (default is still "vcSessionCookie") vcsim: add override mechanism for session mapping On the simulator side, API endpoints can specify where a session is sourced from. Default is still the "vmware_soap_session" HTTP Cookie. The pbm simulator now specifies the "vcSessionCookie" SOAP Header, behaving as real pbm/VC does. Signed-off-by: Doug MacEachern <dougm@broadcom.com>
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Jan 7, 2025
In 1918984 / PR vmware#3636 we deferred the http.CookieJar lookup until request time. Fallback to using Path="/" if initial lookup fails. Signed-off-by: Doug MacEachern <dougm@broadcom.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sessions are consumed by API endpoints via one of:
The soap.Client had always set the SOAP Header cookie regardless if consumed by an API endpoint.
Clients must now opt-in to this behavior if they need it, such as pbm and vslm.
This also allows clients to change the name of soap.Header.Cookie (default is still "vcSessionCookie")
vcsim: add override mechanism for session mapping
On the simulator side, API endpoints can specify where a session is sourced from. Default is still the "vmware_soap_session" HTTP Cookie. The pbm simulator now specifies the "vcSessionCookie" SOAP Header, behaving as real pbm/VC does.