Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): add vcsim to rpm #3414

Merged
merged 1 commit into from
Apr 12, 2024
Merged

build(deps): add vcsim to rpm #3414

merged 1 commit into from
Apr 12, 2024

Conversation

smitterl
Copy link
Contributor

Description

Previously, we enabled rpm builds. However, only 'govc' was added. Let's add 'vcsim', too, as the package name 'govmomi' implies it.

Closes: #3413

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Execute goreleaser goreleaser release --clean --snapshot --rm-dist --verbose --skip docker,homebrew; install rpm on x86_64; call govc --help; call vcsim -h

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Closes: vmware#3413

Previously, we enabled rpm builds. However, only 'govc' was added.
Let's add 'vcsim', too, as the package name 'govmomi' implies it.

Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @smitterl

@dougm dougm merged commit 6deb7bf into vmware:main Apr 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builds(deps): add vcsim to rpm
2 participants