Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collector klog flag not supported error #311

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

heanlan
Copy link
Contributor

@heanlan heanlan commented Jun 13, 2023

Add registration of klog flags

Fixes: #306

Add registration of klog flags

Fixes: vmware#306

Signed-off-by: heanlan <hanlan@vmware.com>
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #311 (32f80f2) into main (636ea41) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   73.54%   73.54%           
=======================================
  Files          18       18           
  Lines        2786     2786           
=======================================
  Hits         2049     2049           
  Misses        572      572           
  Partials      165      165           
Flag Coverage Δ
integration-tests 51.31% <ø> (ø)
unit-tests 72.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@heanlan heanlan requested a review from yanjunz97 June 13, 2023 02:55
@@ -48,7 +48,6 @@ spec:
spec:
containers:
- args:
- --v=0
Copy link
Contributor

@yuntanghsu yuntanghsu Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will 0 be used in logs?

Copy link
Contributor Author

@heanlan heanlan Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, 0 is the default log level

Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heanlan heanlan merged commit 49bed1f into vmware:main Jun 13, 2023
@heanlan heanlan deleted the fix-collector-yaml branch June 13, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipfix collector pod in error state when trying to deploy from main branch
4 participants