Skip to content

[Frontend] Support embeddings in the run_batch API #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 9, 2024

Conversation

pooyadavoodi
Copy link
Contributor

Currently run_batch which is the offline batching API only supports chat completion. This PR adds embedding supports to run_batch. The PR also adds support for empty lines (or lines with only whitespace) in the input file of run_batch.

Copy link

github-actions bot commented Aug 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, do you mind adding a simple example to examples/offline_inference_openai.md?

@pooyadavoodi
Copy link
Contributor Author

Looks great, do you mind adding a simple example to examples/offline_inference_openai.md?

Thanks @wuisawesome
I updated the md file.
I wrote that vllm >= 0.5.5 is required as that's the next version that will be released. Is that okay?

@wuisawesome
Copy link
Contributor

I wrote that vllm >= 0.5.5 is required as that's the next version that will be released. Is that okay?

Yep!

@simon-mo simon-mo merged commit 249b882 into vllm-project:main Aug 9, 2024
16 of 18 checks passed
@pooyadavoodi pooyadavoodi deleted the batch_embed branch August 9, 2024 17:15
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Co-authored-by: Simon Mo <simon.mo@hey.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Co-authored-by: Simon Mo <simon.mo@hey.com>
Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants