[CI/Build] Add health check #4868
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudotensor
force-pushed
the
health_check
branch
from
cfb0da0
to
e7f7b01
Compare
|
Can you explain a bit about what |
It's explained in those links. But basically, if one uses autoheal docker image to monitor other images that have the HEALTHCHECK present, then that autoheal will restart the image if the health condition fails. Often vLLM fails, but the entire image still goes on in unhealthy state. It's built into moby, just not built into docker and is currently as separate image as explained in those links: moby/moby#23218 |
mgoin
reviewed
May 19, 2024
| # https://docs.docker.com/reference/dockerfile/#healthcheck | ||
| # https://hub.docker.com/r/willfarrell/autoheal/ | ||
| HEALTHCHECK --interval=5m --timeout=10s \ | ||
| CMD curl -f http://localhost/health || exit 1 |
There was a problem hiding this comment.
nit but 4 spaces indent is standard for this file
Suggested change
| CMD curl -f http://localhost/health || exit 1 | |
| CMD curl -f http://localhost/health || exit 1 |
Comment on lines
+141
to
+142
| # https://docs.docker.com/reference/dockerfile/#healthcheck | ||
| # https://hub.docker.com/r/willfarrell/autoheal/ |
There was a problem hiding this comment.
Please leave a written out comment before sharing these links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hub.docker.com/r/willfarrell/autoheal/
https://docs.docker.com/reference/dockerfile/#healthcheck
To deal with issues like this:
#4108
#4344
FIX #4867