Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix LoRA extra vocab size #15047

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

jeejeelee
Copy link
Collaborator

FIX #15036

Fix
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 18, 2025
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Fix LoRA extra vocal size [Bugfix] Fix LoRA extra vocab size Mar 18, 2025
@DarkLight1337
Copy link
Member

Unblocked LoRA tests - we can merge this once they pass

@vllm-bot vllm-bot merged commit 46c759c into vllm-project:main Mar 18, 2025
15 of 21 checks passed
@DarkLight1337 DarkLight1337 added this to the v0.8.0 milestone Mar 18, 2025
simon-mo pushed a commit that referenced this pull request Mar 18, 2025
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee deleted the fix-lora-extra-vocal-size branch March 19, 2025 01:27
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Apr 1, 2025

Verified

This commit was signed with the committer’s verified signature.
gmarinho2 Gabriel Marinho
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tensor shape mismatch for --lora-extra-vocab-size 0
3 participants