Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix interface for Olmo2 on V1 #14976

Merged
merged 2 commits into from
Mar 17, 2025
Merged

[Bugfix] Fix interface for Olmo2 on V1 #14976

merged 2 commits into from
Mar 17, 2025

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Mar 17, 2025

FIXES #14975

Signed-off-by: Roger Wang <ywang@roblox.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 17, 2025
@ywang96 ywang96 added this to the v0.8.0 milestone Mar 17, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vllm-bot vllm-bot merged commit 5340b0e into main Mar 17, 2025
11 of 14 checks passed
@vllm-bot vllm-bot deleted the olmo2-v1 branch March 17, 2025 18:26
simon-mo pushed a commit that referenced this pull request Mar 17, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Apr 1, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][V1]: allenai/OLMo-2-0325-32B-Instruct - unexpected keyword argument 'inputs_embeds'
4 participants