Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Attention] Remove slow setattr in MLA #14769

Merged
merged 2 commits into from
Mar 13, 2025
Merged

[Attention] Remove slow setattr in MLA #14769

merged 2 commits into from
Mar 13, 2025
+7 −2

Conversation

LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Mar 13, 2025 •
edited by github-actions bot
Loading

image

Partial undo of #14471 which was a revert of #14384

@LucasWilkinson
fix slowattr
483e95f 
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@LucasWilkinson
format
Loading
Loading status checks…
3669abf 
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@LucasWilkinson LucasWilkinson mentioned this pull request Mar 13, 2025
Merged
@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 13, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 13, 2025 20:09
@robertgshaw2-redhat robertgshaw2-redhat merged commit d47807b into vllm-project:main Mar 13, 2025
47 checks passed
youkaichao
youkaichao reviewed Mar 14, 2025
View reviewed changes
vllm/model_executor/layers/rotary_embedding.py
Comment on lines +166 to +167
if self.cos_sin_cache.device != query.device or \
self.cos_sin_cache.dtype != query.dtype:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been curious about this for a long time. when will this condition be false? i.e. the query has different device / dtype from the cos_sin_cache .

richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
@LucasWilkinson @richardsliu
[Attention] Remove slow setattr in MLA (vllm-project#14769)
37ea34a 
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao

@tlrmchlsmth tlrmchlsmth

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucasWilkinson @tlrmchlsmth @youkaichao @robertgshaw2-redhat