Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Metrics] Updated list of deprecated metrics in v0.8 #14695

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

markmc
Copy link
Collaborator

@markmc markmc commented Mar 12, 2025

These are already marked as deprecated in the code, but they should be listed here too.

See the current state at https://docs.vllm.ai/en/latest/serving/metrics.html

        # Deprecated in 0.8 - KV cache offloading is not used in V1
        # TODO: in 0.9, only enable if show_hidden_metrics=True
        self.gauge_scheduler_swapped = self._gauge_cls(
            name="vllm:num_requests_swapped",
...

The following metrics are deprecated and due to be removed in a future version:

  • (No metrics are currently deprecated)

These are already marked as deprecated in the code, but they
should be listed here too.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@markmc markmc added this to the v0.8.0 milestone Mar 12, 2025
@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 12, 2025
@markmc markmc added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 13, 2025
@DarkLight1337 DarkLight1337 merged commit 9d2b4a7 into vllm-project:main Mar 14, 2025
27 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
…t#14695)

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants