Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Add regex structured output support with xgrammar #14590

Merged
merged 3 commits into from
Mar 11, 2025
Merged

[V1] Add regex structured output support with xgrammar #14590

merged 3 commits into from
Mar 11, 2025
+25 −19

Conversation

russellb
Copy link
Member

[V1] Add regex structured output support with xgrammar

This is built on top of #14563, as the upgraded xgrammar is required for regex
support to work.

Signed-off-by: Russell Bryant rbryant@redhat.com

@russellb russellb requested a review from mgoin as a code owner March 11, 2025 01:38
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@robertgshaw2-redhat
Copy link
Collaborator

👀

WoosukKwon
WoosukKwon approved these changes Mar 11, 2025
View reviewed changes
russellb added 3 commits March 10, 2025 22:35
@russellb
[Build/CI] Upgrade xgrammar to >=0.1.15
4b5bd40 
This update includes support for aarch64 among other fixes and improvements.

Closes vllm-project#11886
Closes vllm-project#13986

Implements part of vllm-project#13894

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb
Switch xgrammar dep to be pinned to 0.1.15
4aa2ff3 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb
[V1] Add regex structured output support with xgrammar
Loading
Loading status checks…
d55cfbd 
This is built on top of vllm-project#14563, as the upgraded xgrammar is required for regex
support to work.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@russellb russellb force-pushed the v1-xgrammar-regex branch from d4042e3 to d55cfbd Compare March 11, 2025 02:37
@russellb russellb mentioned this pull request Mar 11, 2025
Closed
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2025
@DarkLight1337 DarkLight1337 merged commit 4bf82d4 into vllm-project:main Mar 11, 2025
69 checks passed
This was referenced Mar 11, 2025
Closed
Closed
@aarnphm aarnphm mentioned this pull request Mar 11, 2025
Open
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Mar 11, 2025
@russellb @JC1DA
[V1] Add regex structured output support with xgrammar (vllm-project#…
ff20f79 
…14590)

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoosukKwon WoosukKwon

@mgoin mgoin

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@russellb @robertgshaw2-redhat @WoosukKwon @DarkLight1337